Sending Patches: Difference between revisions

From Bluefish Wiki
Jump to navigation Jump to search
(Starting to update the document. cvs->svn transition and update.)
(Update the whole page. First version. Maybe not yet fully complete.)
Line 1: Line 1:
__TOC__
This is a short document how you should send your patches.
This is a short document how you should send your patches.


==Before starting to code==
==Before starting to code==
Line 18: Line 22:
svn co https://bluefish.svn.sourceforge.net/svnroot/bluefish/branches/bluefish_1_0/</pre>
svn co https://bluefish.svn.sourceforge.net/svnroot/bluefish/branches/bluefish_1_0/</pre>


If you already have checked out the code, then please first update it to retreive the latest revision:
If you already have checked out the code, then please first update it to retrieve the latest revision:


<pre>svn update</pre>
<pre>svn update</pre>


Alternatively download the latest snapshot (see also [[Downloading from CVS]]).
Alternatively download the latest snapshot (see also [[Downloading from CVS]]). In this case make a copy of the




==While coding==
==Notes for hackers==


* use tabs, not spaces, for indenting, so everybody can use their own preferred tabsize
The following information is for people wanting to hack on Bluefishs source code.
* comment all public functions like it is done in bf''lib.c and gtk''easy.c (javadoc style, with some small differences), this can be used to create a function reference
 
''' declare all local functions as 'static', declare all non-local functions in the '''''''''.h file
 
* for gtk callback functions, use the name of the signal in the name, and append ''lcb to the function name if it is local, or ''cb for non-local callbacks
===While coding===
 
* for indenting use tabs, not spaces
* comment all public functions like it is done in <tt>bf_lib.c</tt> and <tt>gtk_easy.c</tt> (javadoc style, with some small differences)
<!-- * declare all local functions as 'static' -->
* declare all non-local functions in the .h file
* for gtk callback functions, use the name of the signal in the name, and append '''_lcb''' to the function name if it is local, or '''_cb''' for non-local callbacks
* more to come...
* more to come...


==Before creating the patch==
 
===Before creating the patch===


* run ''make distclean && ./configure && make'' and test if it runs successfull
* run ''make distclean && ./configure && make'' and test if it runs successfull
* if you have the possibility do this both with gcc-2.95 and gcc-3. as compiler
* if you have the possibility do this even with gcc-2.95 and gcc-3 as compiler
* more to come later...
* more to come later...


==Now create the patch==


suppose you have two directories, original-tree and my-tree
==Notes for translators==
* run make distclean in both trees
 
* cd to the parent dir of the two trees
The following information is for people wanting to translate Bluefish into their language and update an existing language.
* run ''diff -Naur original-tree my-tree | bzip2 -9c > patchbla.diff.bz2''
 
 
===Before you start===
 
Before you start contact our translation coordinator. To get a very last and complete template file run:
 
<pre>LINGUAS="your_lang" make update-po</pre>
 
After this step you can begin to work on these translations. For a list of all <tt>.po</tt> files for your language use <code>find . -name your_lang.po</code>. If there are no <tt>.po</tt> file for your language, please contact our translaton coordinator. Files for a new translation can also be obtained with:
 
<pre>find . -name "*.pot" -execdir cp "{}" your_lang.po ";"</pre>
 
 
===Before creating the patch===
 
The following step is not necessary but it will help you finding issues, which must be fixed, before your changes can be committed to the subversion tree. It requires an installation of the gettext tools.
 
<pre>find . -name lang.po | xargs msgcat --use-first -o - | msgfmt -o /dev/null --statistics -</pre>
 
This step should report missing or fuzzy translations and even errors in your .po file. It won't report wrong translations hough.
 
 
==Create the patch==
 
===Create the patch against the Subversion tree===
 
Before you create a patch in the subversion tree you should again update it to the latest SVN revision via <code>svn update</code> and resolve all occuring conflicts (if any). Then produce the patch by using the <code>svn diff</code> command as shown below:
 
<pre>svn diff | bzip2 -9c &gt; your_patch.diff.bz2
svn diff src/foo.c data/bflang/foo.bflang2 | bzip2 -9c &gt; your_patch.diff.bz2</pre>
 
 
====Special notes for translators====
 
In case you have updated all <tt>your_lang.po</tt> files in the subversion tree and you want to send us a patch, you can use:
 
<pre>find . -name your_lang.po | xargs svn diff | bzip2 -9c &gt; your_lang.diff.bz2</pre>
 
Alternatively you can send us the files too by adding them to a tarball:
 
<pre>find . -name your_lang.po | xargs tar -cjf your_lang.tar.bz2</pre>
 
 
===Create the patch against the tarball===
 
Suppose you have two directories, the original tree (e.g. <tt>bluefish-unstable-1.3.6.orig</tt>) and your working tree (e.g. <tt>bluefish-unstable-1.3.6</tt>), then use the <tt>diff</tt> comand to produce a patch. Make sure you
 
* run <code>make distclean</code> (or even <code>make maintainer-clean</code>) in both trees
* <code>cd</code> to the parent dir of the two trees
* run <code>diff -purN original-tree working-tree | bzip2 -9c &gt; patch.diff.bz2</code>


== Sending the patch==
==Sending the patch==


You can send patches to the development mailinglist, or attach them to a bugzilla bugreport.
You can send patches to the development mailinglist or attach them to a bugzilla bugreport.


simple isn't it?
simple isn't it?

Revision as of 13:14, 18 September 2009


This is a short document how you should send your patches.


Before starting to code

We have two main branches in our Subversion tree:

Make a checkout of the branch you want to work on. Sometimes we also have some branches, when we work on new major features or rewrites. But you usually want one of the above.


Getting the code

To checkout one of the branches

svn co https://bluefish.svn.sourceforge.net/svnroot/bluefish/trunk/bluefish/
svn co https://bluefish.svn.sourceforge.net/svnroot/bluefish/branches/bluefish_1_0/

If you already have checked out the code, then please first update it to retrieve the latest revision:

svn update

Alternatively download the latest snapshot (see also Downloading from CVS). In this case make a copy of the


Notes for hackers

The following information is for people wanting to hack on Bluefishs source code.


While coding

  • for indenting use tabs, not spaces
  • comment all public functions like it is done in bf_lib.c and gtk_easy.c (javadoc style, with some small differences)
  • declare all non-local functions in the .h file
  • for gtk callback functions, use the name of the signal in the name, and append _lcb to the function name if it is local, or _cb for non-local callbacks
  • more to come...


Before creating the patch

  • run make distclean && ./configure && make and test if it runs successfull
  • if you have the possibility do this even with gcc-2.95 and gcc-3 as compiler
  • more to come later...


Notes for translators

The following information is for people wanting to translate Bluefish into their language and update an existing language.


Before you start

Before you start contact our translation coordinator. To get a very last and complete template file run:

LINGUAS="your_lang" make update-po

After this step you can begin to work on these translations. For a list of all .po files for your language use find . -name your_lang.po. If there are no .po file for your language, please contact our translaton coordinator. Files for a new translation can also be obtained with:

find . -name "*.pot" -execdir cp "{}" your_lang.po ";"


Before creating the patch

The following step is not necessary but it will help you finding issues, which must be fixed, before your changes can be committed to the subversion tree. It requires an installation of the gettext tools.

find . -name lang.po | xargs msgcat --use-first -o - | msgfmt -o /dev/null --statistics -

This step should report missing or fuzzy translations and even errors in your .po file. It won't report wrong translations hough.


Create the patch

Create the patch against the Subversion tree

Before you create a patch in the subversion tree you should again update it to the latest SVN revision via svn update and resolve all occuring conflicts (if any). Then produce the patch by using the svn diff command as shown below:

svn diff | bzip2 -9c > your_patch.diff.bz2
svn diff src/foo.c data/bflang/foo.bflang2 | bzip2 -9c > your_patch.diff.bz2


Special notes for translators

In case you have updated all your_lang.po files in the subversion tree and you want to send us a patch, you can use:

find . -name your_lang.po | xargs svn diff | bzip2 -9c > your_lang.diff.bz2

Alternatively you can send us the files too by adding them to a tarball:

find . -name your_lang.po | xargs tar -cjf your_lang.tar.bz2


Create the patch against the tarball

Suppose you have two directories, the original tree (e.g. bluefish-unstable-1.3.6.orig) and your working tree (e.g. bluefish-unstable-1.3.6), then use the diff comand to produce a patch. Make sure you

  • run make distclean (or even make maintainer-clean) in both trees
  • cd to the parent dir of the two trees
  • run diff -purN original-tree working-tree | bzip2 -9c > patch.diff.bz2

Sending the patch

You can send patches to the development mailinglist or attach them to a bugzilla bugreport.

simple isn't it?